linux-kernel - Re: [PATCH v5 0/3] usb: typec: ucsi: Adding support for UCSI 3.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 13:40:26 -0800
From: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>, linux-usb@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: pmalani@...omium.org, jthies@...gle.com, 
	"Christian A. Ehrhardt" <lk@...e.de>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Fabrice Gasnier <fabrice.gasnier@...s.st.com>, Hans de Goede <hdegoede@...hat.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Rajaram Regupathy <rajaram.regupathy@...el.com>, 
	Saranya Gopal <saranya.gopal@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/3] usb: typec: ucsi: Adding support for UCSI 3.0

On Fri, Feb 9, 2024 at 2:38 PM Abhishek Pandit-Subedi
<abhishekpandit@...omium.org> wrote:
>
>
> Hi Heikki,
>
> This series starts the work adding UCSI 3.0 support to the UCSI driver.
>
> There's a couple of pieces to start here:
> * Add version checks and limit read size on 1.2.
> * Update Connector Status and Connector Capability structures.
> * Expose Partner PD revision from Capability data.
>
> These were tested against on a 6.6 kernel running a usermode PPM against
> a Realtek Evaluation board.
>
> One additional note: there are a lot more unaligned fields in UCSI now
> and the struct definitions are getting a bit out of hand. We can discuss
> alternate mechanisms for defining these structs in the patch that
> changes these structures.
>
> Thanks,
> Abhishek
>
> Changes in v5:
>   - Change min_t to clamp
>
> Changes in v4:
>   - Added missing Tested-By tags from v1 and reviewed-by tags.
>   - Fix BCD translation of PD Major Rev
>   - Replace IS_MIN_VERSION macro and just compare version directly.
>
> Changes in v3:
>   - Change include to asm/unaligned.h and reorder include.
>
> Changes in v2:
>   - Changed log message to DEBUG
>   - Formatting changes and update macro to use brackets.
>   - Fix incorrect guard condition when checking connector capability.
>
> Abhishek Pandit-Subedi (3):
>   usb: typec: ucsi: Limit read size on v1.2
>   usb: typec: ucsi: Update connector cap and status
>   usb: typec: ucsi: Get PD revision for partner
>
>  drivers/usb/typec/ucsi/ucsi.c | 49 +++++++++++++++++++++++--
>  drivers/usb/typec/ucsi/ucsi.h | 67 ++++++++++++++++++++++++++++++++---
>  2 files changed, 110 insertions(+), 6 deletions(-)
>
> --
> 2.43.0.687.g38aa6559b0-goog
>

Hi Greg,

This series should be ready to merge. Please take a look.

Thanks,
Abhishek