linux-kernel - Re: [PATCH v2] mm: document memalloc_noreclaim_save() and memalloc_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 15:55:57 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, Michal Hocko
 <mhocko@...nel.org>, Mel Gorman <mgorman@...hsingularity.net>, Matthew
 Wilcox <willy@...radead.org>, Mike Rapoport <rppt@...nel.org>, Pasha
 Tatashin <pasha.tatashin@...een.com>, Kent Overstreet
 <kent.overstreet@...ux.dev>, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v2] mm: document memalloc_noreclaim_save() and
 memalloc_pin_save()

On Thu, 15 Feb 2024 10:58:28 +0100 Vlastimil Babka <vbabka@...e.cz> wrote:
>
> ...
>
> v2: fix issues that Mike pointed out

Cool.

> sending as replacement instead of fixup because I've used the wrong
> address for Kent and it became part of Cc: tag in the mm tree.

akpm has editor ;)

> + * This function marks the beginning of the __GFP_MEMALLOC allocation scope.
> ...
>
> + * This function marks the beginning of the ~__GFP_MOVABLE allocation scope.

pet peeves.  We can assume that the reader knows that this is a
function!  Perhaps we should teach checkpatch to whine.

Like "the function foo" and "the function foo()" in changelogs. 
"foo()" is enough!