linux-kernel - Re: [PATCH net-next] net: smsc95xx: add support for SYS TEC USB-SPEmodule1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13454529.uLZWGnKmhe@steina-w>
Date: Thu, 15 Feb 2024 08:50:00 +0100
From: Alexander Stein <alexander.stein@...tq-group.com>
To: steve.glendinning@...well.net, UNGLinuxDriver@...rochip.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, Andre Werner <andre.werner@...tec-electronic.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, daniel.krueger@...tec-electronic.com, Andre Werner <andre.werner@...tec-electronic.com>
Subject: Re: [PATCH net-next] net: smsc95xx: add support for SYS TEC USB-SPEmodule1

Hi Andre,

Am Mittwoch, 14. Februar 2024, 14:25:07 CET schrieb Andre Werner:
> This patch adds support for the SYS TEC USB-SPEmodule1 10Base-T1L
> ethernet device to the existing smsc95xx driver by adding the new
> USB VID/PID pair.
> 
> Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>
> ---
>  drivers/net/usb/smsc95xx.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index a530f20ee257..bb4e62a93d96 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -2109,6 +2109,11 @@ static const struct usb_device_id products[] = {
>  		USB_DEVICE(0x184F, 0x0051),
>  		.driver_info = (unsigned long)&smsc95xx_info,
>  	},
> +	{
> +		/* SYSTEC USB-SPEmodule1 10BASE-T1L Ethernet Device */
> +		USB_DEVICE(0x0878, 0x1400),
> +		.driver_info = (unsigned long)&smsc95xx_info,
> +	},

IMHO entries should be sorted by USB Vendor ID. So this goes before 
Microchip's EVB-LAN8670-USB.

Best regards,
Alexander

>  	{ },		/* END */
>  };
>  MODULE_DEVICE_TABLE(usb, products);


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/