lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 15 Feb 2024 09:20:45 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>, "chunkuang.hu@...nel.org"
	<chunkuang.hu@...nel.org>
CC: "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...labora.com" <kernel@...labora.com>, "daniel@...ll.ch"
	<daniel@...ll.ch>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"amergnat@...libre.com" <amergnat@...libre.com>, "airlied@...il.com"
	<airlied@...il.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "fshao@...omium.org" <fshao@...omium.org>
Subject: Re: [PATCH v6 8/9] drm/mediatek: dsi: Compress of_device_id entries
 and add sentinel

Hi, Angelo:

On Thu, 2024-02-15 at 09:53 +0100, AngeloGioacchino Del Regno wrote:
> All entries fit in 82 columns, which is acceptable: compress all of
> the mtk_dsi_of_match[] entries to a single line for each.
> 
> While at it, also add the usual sentinel comment to the last entry.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Reviewed-by: Alexandre Mergnat <amergnat@...libre.com>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 195ff4dfc3a3..b644505de98a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1204,17 +1204,12 @@ static const struct mtk_dsi_driver_data
> mt8188_dsi_driver_data = {
>  };
>  
>  static const struct of_device_id mtk_dsi_of_match[] = {
> -	{ .compatible = "mediatek,mt2701-dsi",
> -	  .data = &mt2701_dsi_driver_data },
> -	{ .compatible = "mediatek,mt8173-dsi",
> -	  .data = &mt8173_dsi_driver_data },
> -	{ .compatible = "mediatek,mt8183-dsi",
> -	  .data = &mt8183_dsi_driver_data },
> -	{ .compatible = "mediatek,mt8186-dsi",
> -	  .data = &mt8186_dsi_driver_data },
> -	{ .compatible = "mediatek,mt8188-dsi",
> -	  .data = &mt8188_dsi_driver_data },
> -	{ },
> +	{ .compatible = "mediatek,mt2701-dsi", .data =
> &mt2701_dsi_driver_data },
> +	{ .compatible = "mediatek,mt8173-dsi", .data =
> &mt8173_dsi_driver_data },
> +	{ .compatible = "mediatek,mt8183-dsi", .data =
> &mt8183_dsi_driver_data },
> +	{ .compatible = "mediatek,mt8186-dsi", .data =
> &mt8186_dsi_driver_data },
> +	{ .compatible = "mediatek,mt8188-dsi", .data =
> &mt8188_dsi_driver_data },
> +	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
>  

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ