linux-kernel - [PATCH] Perf: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 17:26:59 +0800
From: Pairman Guo <pairmanxlr@...il.com>
To: mingo@...hat.com,
	namhyung@...nel.org
Cc: linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Pairman Guo <pairmanxlr@...il.com>
Subject: [PATCH] Perf: Use fallthrough pseudo-keyword

Hi maintainers,

There is a usage of ``/* fall thru */`` in a switch statement in
hist_browser__handle_hotkey() that have long been untouched.
This patch replaced it with the better and proper pseudo-keyword
``fallthrough;``.

Please merge if it is the case. Thank you in advance.

Signed-off-by: Pairman Guo <pairmanxlr@...il.com>
---
 tools/perf/ui/browsers/hists.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 0c02b3a8e..aed835946 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -732,7 +732,7 @@ static int hist_browser__handle_hotkey(struct hist_browser *browser, bool warn_l
 	case '+':
 		if (hist_browser__toggle_fold(browser))
 			break;
-		/* fall thru */
+		fallthrough;
 	default:
 		return -1;
 	}
-- 
2.43.1