linux-kernel - Re: [PATCH] Staging: rtl8192e: rtl819x_HTProc: Removed braces from single statement block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 10:32:41 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Aaron Parfitt <aaronparfitt123@...il.com>, gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] Staging: rtl8192e: rtl819x_HTProc: Removed braces from
 single statement block

Hi Aaron,

looks OK but can we make the subject more unique. Maybe like this:

[PATCH] Staging: rtl8192e: Removed braces from single statement block in 
ht_on_assoc_rsp

Or is this getting to long?

I propose the description to be like:

Remove braces from single statement blocks to clear checkpatch warning.

If you change this you need to make a v2 with changelog.

Bye Philipp

On 13.02.24 08:46, Aaron Parfitt wrote:
> Fixed code style issue
>
> Signed-off-by: Aaron Parfitt <aaronparfitt123@...il.com>
> ---
>   drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 6d0912f90198..49b882c363bf 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -480,9 +480,9 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
>   	}
>   
>   	ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity;
> -	if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
> +	if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K)
>   		ht_info->current_ampdu_enable = false;
> -	}
> +
>   	ht_info->cur_rx_reorder_enable = 1;
>   
>   	if (pPeerHTCap->MCS[0] == 0)