linux-kernel - Re: [PATCH v3] mm: swap: async free swap slot cache entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF8kJuM8609V48u6gz3tXiB67LofFghE1xEQU0q8t9o+sSiJdg@mail.gmail.com>
Date: Wed, 14 Feb 2024 17:03:48 -0800
From: Chris Li <chrisl@...nel.org>
To: Tim Chen <tim.c.chen@...ux.intel.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org, Wei Xu <weixugc@...gle.com>, Yu Zhao <yuzhao@...gle.com>, 
	Greg Thelen <gthelen@...gle.com>, Chun-Tse Shao <ctshao@...gle.com>, 
	Yosry Ahmed <yosryahmed@...gle.com>, Michal Hocko <mhocko@...e.com>, 
	Mel Gorman <mgorman@...hsingularity.net>, Huang Ying <ying.huang@...el.com>, 
	Nhat Pham <nphamcs@...il.com>, Kairui Song <kasong@...cent.com>, 
	Barry Song <v-songbaohua@...o.com>
Subject: Re: [PATCH v3] mm: swap: async free swap slot cache entries

On Wed, Feb 14, 2024 at 2:54 PM Tim Chen <tim.c.chen@...ux.intel.com> wrote:
>
> On Wed, 2024-02-14 at 10:56 -0800, Chris Li wrote:
> > On Tue, Feb 13, 2024 at 4:08 PM Tim Chen <tim.c.chen@...ux.intel.com> wrote:
> > >
> > >
> > > >
> > > >  extern bool swap_slot_cache_enabled;
> > > > +extern uint8_t slot_cache_async_free __read_mostly;
> > >
> > > Why wouldn't you enable the async_free always?
> > > Otherwise the patch looks fine to me.
> >
> > Thanks for the feedback.
> >
> > Just in case someone doesn't care about this optimization and wants to
> > opt out this behavior?
> > Anyway, I am happy to update the patch without the sysfs control file as well.
> >
>
> At least I couldn't see a downside to enable it always in the latest
> patch.  I think adding an extra sysfs is unnecessary.

Thanks, I just sent out V4 to remove the sysfs control file.

Chris