linux-kernel - Re: [PATCH CFT] usb: ucsi_ccg: Fix command completion handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024021504-oven-worst-5c15@gregkh>
Date: Thu, 15 Feb 2024 12:07:20 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "Christian A. Ehrhardt" <lk@...e.de>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Sing-Han Chen <singhanc@...dia.com>,
	Haotien Hsu <haotienh@...dia.com>,
	Utkarsh Patel <utkarsh.h.patel@...el.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Wayne Chang <waynec@...dia.com>, WK Tsai <wtsai@...dia.com>
Subject: Re: [PATCH CFT] usb: ucsi_ccg: Fix command completion handling

On Thu, Feb 15, 2024 at 11:10:24AM +0100, Christian A. Ehrhardt wrote:
> In case of a spurious or otherwise delayed interrupt
> it is possible that CCI still reports the previous completion.
> For this reason the UCSI spec provides different completion
> bits for normal commands and for UCSI_ACK_CC_CI.
> 
> Only complete a sync command if the correct completion bit
> is set.
> 
> This should avoid the need to clear out CCI before starting
> a command. Thus remove this code.
> 
> Signed-off-by: Christian A. Ehrhardt <lk@...e.de>
> Fixes: e32fd989ac1c ("usb: typec: ucsi: ccg: Move to the new API")

What does "CFT" in your subject line mean?

thanks,

greg k-h