linux-kernel - Re: [PATCH 04/30] sched: make test_*_tsk_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 18:04:00 -0800
From: Ankur Arora <ankur.a.arora@...cle.com>
To: Mark Rutland <mark.rutland@....com>
Cc: Ankur Arora <ankur.a.arora@...cle.com>, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, peterz@...radead.org,
        torvalds@...ux-foundation.org, paulmck@...nel.org,
        akpm@...ux-foundation.org, luto@...nel.org, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org, willy@...radead.org,
        mgorman@...e.de, jpoimboe@...nel.org, jgross@...e.com,
        andrew.cooper3@...rix.com, bristot@...nel.org,
        mathieu.desnoyers@...icios.com, geert@...ux-m68k.org,
        glaubitz@...sik.fu-berlin.de, anton.ivanov@...bridgegreys.com,
        mattst88@...il.com, krypton@...ich-teichert.org, rostedt@...dmis.org,
        David.Laight@...lab.com, richard@....at, mjguzik@...il.com,
        jon.grimm@....com, bharata@....com, raghavendra.kt@....com,
        boris.ostrovsky@...cle.com, konrad.wilk@...cle.com
Subject: Re: [PATCH 04/30] sched: make test_*_tsk_thread_flag() return bool


Mark Rutland <mark.rutland@....com> writes:

> On Mon, Feb 12, 2024 at 09:55:28PM -0800, Ankur Arora wrote:
>> All users of test_*_tsk_thread_flag() treat the result as boolean.
>> This is also true for the underlying test_and_*_bit() operations.
>>
>> Change the return type to bool.
>>
>> Cc: Peter Ziljstra <peterz@...radead.org>
>> Originally-by: Thomas Gleixner <tglx@...utronix.de>
>> Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
>> Signed-off-by: Ankur Arora <ankur.a.arora@...cle.com>
>
> Acked-by: Mark Rutland <mark.rutland@....com>

Thanks.

> I think this makes sense on its own regardless of the rest of the series; it
> might make sense to move it to the start of the series so that it can easily be
> picked up even if the rest needs work.

Yeah that makes sense. Will do.

--
ankur