linux-kernel - Re: [PATCH v2 09/15] auxdisplay: linedisp: Add support for overriding character mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 14:14:56 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Robin van der Gracht <robin@...tonic.nl>,
	Paul Burton <paulburton@...nel.org>
Subject: Re: [PATCH v2 09/15] auxdisplay: linedisp: Add support for
 overriding character mapping

On Thu, Feb 15, 2024 at 11:36:47AM +0100, Geert Uytterhoeven wrote:
> On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

..

> > +static const struct attribute_group linedisp_group = {
> > +       .is_visible     = linedisp_attr_is_visible,
> 
> Shouldn't that be .is_bin_visible?
> 
> > +       .attrs          = linedisp_attrs,
> 
> Likewise, .bin_attrs?
> But that is a pre-existing issue in the ht16k33 driver.

I was wondering myself, but we have no infrastructure for that
(there are no DEVICE_BIN_ATTR_*() helpers, nor bin_attr member
 in struct device attribute).

As you pointed out, it's preexisted issue and should be addressed
separately and not only in this driver.

> > +};
> > +__ATTRIBUTE_GROUPS(linedisp);

-- 
With Best Regards,
Andy Shevchenko