linux-kernel - Re: [PATCH v2 07/15] auxdisplay: linedisp: Group line display drivers together

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWqfUHGP4t17=4UVE0uOFqwpc7dF8D9MCU4EmdYSnfjDQ@mail.gmail.com>
Date: Thu, 15 Feb 2024 13:35:32 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Robin van der Gracht <robin@...tonic.nl>, Paul Burton <paulburton@...nel.org>
Subject: Re: [PATCH v2 07/15] auxdisplay: linedisp: Group line display drivers together

Hi Andy,

On Thu, Feb 15, 2024 at 12:30 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Thu, Feb 15, 2024 at 11:05:00AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> > >  obj-$(CONFIG_CHARLCD)          += charlcd.o
> > >  obj-$(CONFIG_HD44780_COMMON)   += hd44780_common.o
> > > -obj-$(CONFIG_ARM_CHARLCD)      += arm-charlcd.o
> > > +obj-$(CONFIG_HD44780)          += hd44780.o
> > > +obj-$(CONFIG_LCD2S)            += lcd2s.o
> > >  obj-$(CONFIG_KS0108)           += ks0108.o
> > >  obj-$(CONFIG_CFAG12864B)       += cfag12864b.o cfag12864bfb.o
> > > -obj-$(CONFIG_IMG_ASCII_LCD)    += img-ascii-lcd.o
> > > -obj-$(CONFIG_HD44780)          += hd44780.o
> > > -obj-$(CONFIG_HT16K33)          += ht16k33.o
> > > -obj-$(CONFIG_PARPORT_PANEL)    += panel.o
> > > -obj-$(CONFIG_LCD2S)            += lcd2s.o
> > >  obj-$(CONFIG_LINEDISP)         += line-display.o
> > > +obj-$(CONFIG_IMG_ASCII_LCD)    += img-ascii-lcd.o
> > > +obj-$(CONFIG_HT16K33)          += ht16k33.o
> > > +obj-$(CONFIG_ARM_CHARLCD)      += arm-charlcd.o
> > > +obj-$(CONFIG_PARPORT_PANEL)    += panel.o
> >
> > IMHO it hurts to not sort Makefile entries alphabetically.
>
> I can add blank lines to follow the same grouping as in Kconfig. Would it work
> for you?

Unlike Kconfig, this is not user-visible.
Most Makefiles use sorted entries.  If they look unsorted, people will
just add new entries at the end.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds