linux-kernel - Re: [RESEND PATCH v4 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 07:44:29 -0600
From: Rob Herring <robh@...nel.org>
To: Shenghao Ding <shenghao-ding@...com>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	manisha.agrawal@...com, hnagalla@...com, praneeth@...com,
	lgirdwood@...il.com, linux-sound@...r.kernel.org,
	conor+dt@...nel.org, aviel@...com, perex@...ex.cz, pdjuandi@...com,
	linux-kernel@...r.kernel.org, tiwai@...e.de,
	devicetree@...r.kernel.org, tiwai@...e.com, mohit.chawla@...com,
	13916275206@....com, s-hari@...com, soyer@....hu,
	broonie@...nel.org, jkhuang3@...com
Subject: Re: [RESEND PATCH v4 4/4] ASoc: dt-bindings: PCM6240: Add initial DT
 binding


On Thu, 08 Feb 2024 19:40:48 +0800, Shenghao Ding wrote:
> PCM6240 family chips are popular among audio customers, in spite of only a
> portion of the functionality of codec, such as ADC or DAC, and so on, for
> different Specifications, range from Personal Electric to Automotive
> Electric, even some professional fields.yet their audio performance is far
> superior to the codec's, and cost is lower than codec, and much easier to
> program than codec.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@...com>
> 
> ---
> Change in v4:
>  - Rewrite the subject to match something similar to other commits.
>  - And none of them are compatible with something.
>  - minItems, then maxItems.
>  - Drop reset-gpios description
>  - Remove the repeated reg descriptions and reg constraints.
>  - Drop redundant spaces.
>  - Add missing line breaks between blocks and additionalProperties.
>  - Correct compatibility issue on adc6120 and pcm6240.
>  - All these chips have only a portion of the functionality of codec,
>    such as ADC or DAC, and so on, but their audio performance is far
>    superior to the codec's, and cost is lower than codec, and much easier
>    to program than codec. Simply one or two register settings can enable
>    them to work. Init for these chips are hardware reset or software reset.
>    As to some audio filter params for internal filters, it is up to the
>    special user cases, which can be saved into the bin file. The default
>    value also can work well.
>  - Add blank line before reg.
>  - remove unneeded items and if branches.
>  - Add missing compatible devices, such as adc6120, etc.
>  - Add necessary people into the list for DTS review
>  - correct misaligned.
>  - Remove dix4192
>  - simplify the compatibility
> ---
>  .../devicetree/bindings/sound/ti,pcm6240.yaml | 172 ++++++++++++++++++
>  1 file changed, 172 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ti,pcm6240.yaml
> 

Reviewed-by: Rob Herring <robh@...nel.org>