linux-kernel - Re: [PATCH] backlight: ktd2801: depend on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5772702.DvuYhMxLoT@radijator>
Date: Thu, 15 Feb 2024 15:20:50 +0100
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Daniel Thompson <daniel.thompson@...aro.org>,
 Jingoo Han <jingoohan1@...il.com>, Helge Deller <deller@....de>,
 Arnd Bergmann <arnd@...nel.org>, Karel Balej <balejk@...fyz.cz>,
 dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org,
 linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: ktd2801: depend on GPIOLIB

On Thursday, February 15, 2024 2:31:37 PM CET Linus Walleij wrote:
> On Tue, Feb 13, 2024 at 7:13 PM Duje Mihanović <duje.mihanovic@...le.hr> 
wrote:
> > LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it:
> > 
> > WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> > 
> >   Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> >   Selected by [m]:
> >   - BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE 
[=m]
> > 
> > Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support")
> > Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Technically you can also select GPIOLIB, because it is available on
> all platforms, so it may be easier for users, but then you never know
> which GPIOs you get in practice.

Now that I think of it, wouldn't that be the better solution? I opted for 
"depends on" only because Arnd did the same in his KTD2692 patch, but if 
select is better (and it seems to be for users) then I'd go for that in both 
patches.

Regards,
-- 
Duje