linux-kernel - Re: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 08:56:54 -0600
From: Rob Herring <robh@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: linux-leds@...r.kernel.org,
	Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
	linux-kernel@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
	Conor Dooley <conor.dooley@...rochip.com>,
	devicetree@...r.kernel.org, Pavel Machek <pavel@....cz>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Christian Marangi <ansuelsmth@...il.com>,
	Lee Jones <lee@...nel.org>
Subject: Re: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low


On Tue, 13 Feb 2024 20:13:41 +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> active-low was lifted to the common schema for leds, but it went
> unnoticed that the leds-multicolour binding had "additionalProperties:
> false" where the other users had "unevaluatedProperties: false", thereby
> disallowing active-low for multicolour leds. Explicitly permit it again.
> 
> Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> 
> I'm just assuming this is intentionally restrictive, if its not, we
> could easily just change this to uneval: false.
> 
> CC: Pavel Machek <pavel@....cz>
> CC: Lee Jones <lee@...nel.org>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: Sven Schwermer <sven.schwermer@...ruptive-technologies.com>
> CC: Christian Marangi <ansuelsmth@...il.com>
> CC: linux-leds@...r.kernel.org
> CC: devicetree@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> ---
>  Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@...nel.org>