linux-kernel - Re: [PATCH v5] sparc64: NMI watchdog: fix return value of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9515355-3708-47ef-821d-9e95310b89d3@gaisler.com>
Date: Fri, 16 Feb 2024 17:22:32 +0100
From: Andreas Larsson <andreas@...sler.com>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Igor Zhbanov <izh1979@...il.com>, "David S. Miller"
 <davem@...emloft.net>, sparclinux@...r.kernel.org,
 Sam Ravnborg <sam@...nborg.org>, Andrew Morton <akpm@...ux-foundation.org>,
 stable@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v5] sparc64: NMI watchdog: fix return value of __setup
 handler

On 2024-02-11 06:28, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from setup_nmi_watchdog().
> 
> Fixes: e5553a6d0442 ("sparc64: Implement NMI watchdog on capable cpus.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: Igor Zhbanov <izh1979@...il.com>
> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@...russia.ru
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: sparclinux@...r.kernel.org
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: stable@...r.kernel.org
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Andreas Larsson <andreas@...sler.com>

Applied to my for-next branch.

Thanks,
Andreas