linux-kernel - Re: [PATCH v2] sparc: leon: grpci1: Use devm_platform_ioremap_resource() in grpci1_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbab8a40-ba76-42f5-8f8f-2259ce70e14e@gaisler.com>
Date: Fri, 16 Feb 2024 17:45:21 +0100
From: Andreas Larsson <andreas@...sler.com>
To: Markus Elfring <Markus.Elfring@....de>, sparclinux@...r.kernel.org,
 kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Rob Herring <robh@...nel.org>, Sam Ravnborg <sam@...nborg.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] sparc: leon: grpci1: Use
 devm_platform_ioremap_resource() in grpci1_of_probe()

On 2024-02-06 16:40, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 6 Feb 2024 16:30:15 +0100
> 
> A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42

This line is needlessly long. Could you wrap it or shorten the SHA-1 ID?
You don't need more than the first 12 characters of the SHA-1 ID.

> ("drivers: provide devm_platform_ioremap_resource()").
> 
> * Thus reuse existing functionality instead of keeping duplicate source code.

The same goes for this one. Please keep the width of the commit
description within 75 characters.

> * Delete a local variable which became unnecessary with this refactoring.
> 
> 
> This issue was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Apart from that the patch looks good.

Thanks,
Andreas