linux-kernel - RE: [PATCH] drm: xlnx: dp: Reset DisplayPort IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB59699BE91130AD94A8DC6E7D9C4C2@BL1PR12MB5969.namprd12.prod.outlook.com>
Date: Fri, 16 Feb 2024 16:55:02 +0000
From: "Sagar, Vishal" <vishal.sagar@....com>
To: "Visavalia, Rohit" <rohit.visavalia@....com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "laurent.pinchart@...asonboard.com"
	<laurent.pinchart@...asonboard.com>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org"
	<mripard@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"airlied@...il.com" <airlied@...il.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	"Simek, Michal" <michal.simek@....com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm: xlnx: dp: Reset DisplayPort IP

[AMD Official Use Only - General]

Hi Rohit,

Thanks for the patch.

> -----Original Message-----
> From: dri-devel <dri-devel-bounces@...ts.freedesktop.org> On Behalf Of
> Rohit Visavalia
> Sent: Friday, February 16, 2024 1:41 PM
> To: gregkh@...uxfoundation.org; laurent.pinchart@...asonboard.com;
> maarten.lankhorst@...ux.intel.com; mripard@...nel.org;
> tzimmermann@...e.de; airlied@...il.com; daniel@...ll.ch; Simek, Michal
> <michal.simek@....com>; dri-devel@...ts.freedesktop.org; linux-arm-
> kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Subject: [PATCH] drm: xlnx: dp: Reset DisplayPort IP
>
> Assert DisplayPort reset signal before deasserting,
> it is to clear out any registers programmed before booting kernel.
>
> Signed-off-by: Rohit Visavalia <rohit.visavalia@....com>
> ---
>  drivers/gpu/drm/xlnx/zynqmp_dp.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 1846c4971fd8..5a40aa1d4283 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1714,6 +1714,10 @@ int zynqmp_dp_probe(struct zynqmp_dpsub
> *dpsub)
>               goto err_free;
>       }
>
> +     ret = zynqmp_dp_reset(dp, true);
> +     if (ret < 0)
> +             return ret;
> +
>       ret = zynqmp_dp_reset(dp, false);
>       if (ret < 0)
>               goto err_free;
> --
> 2.25.1

This looks good to me.

Reviewed-by: Vishal Sagar<vishal.sagar@....com>

Regards
Vishal Sagar