linux-kernel - Re: [PATCH v3 1/2] ACPI: use %pe for better readability of errors while printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 16 Feb 2024 19:29:14 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: onkarnath.1@...sung.com
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, "lenb@...nel.org" <lenb@...nel.org>, 
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>, 
	"mingo@...hat.com" <mingo@...hat.com>, "peterz@...radead.org" <peterz@...radead.org>, 
	"juri.lelli@...hat.com" <juri.lelli@...hat.com>, 
	"vincent.guittot@...aro.org" <vincent.guittot@...aro.org>, 
	"dietmar.eggemann@....com" <dietmar.eggemann@....com>, "rostedt@...dmis.org" <rostedt@...dmis.org>, 
	"bsegall@...gle.com" <bsegall@...gle.com>, "mgorman@...e.de" <mgorman@...e.de>, 
	"bristot@...hat.com" <bristot@...hat.com>, "vschneid@...hat.com" <vschneid@...hat.com>, 
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, 
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, Rohit Thapliyal <r.thapliyal@...sung.com>, 
	Maninder Singh <maninder1.s@...sung.com>, "helgaas@...nel.org" <helgaas@...nel.org>, 
	Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
Subject: Re: [PATCH v3 1/2] ACPI: use %pe for better readability of errors
 while printing

On Fri, Feb 16, 2024 at 6:54 AM Onkarnath <onkarnath.1@...sung.com> wrote:
>
> >On Tue, Feb 13, 2024 at 9:20 AM Onkarnarth <onkarnath.1@...sung.com> wrote:
> >>
> >> From: Onkarnath <onkarnath.1@...sung.com>
> >>
> >> As %pe is already introduced, it's better to use it in place of (%ld) for
> >> printing errors in logs. It would enhance readability of logs.
> >>
> >> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> >
> >What exactly is the role of this S-o-b?  Has the person helped you to
> >develop the patch or something else?
> >
>
> Yes It was meant for Co-developed tag, Because We are working collectively for making errors more readable for our product kernel.(5.4)
> And some part of this patch was made by him.
>
> Then we checked that it is also suggested by open source to have %pe for printing errors:
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> So I prepared same changes for open source kernel, and because of smaller patch I kept it as normal signed-off tag only.
> If it is needed I can resend with Co-developed tag.

No need, I can add it for you.  Thanks for the explanation!