linux-kernel - Re: [PATCH 10/33] fsi: aspeed: Add AST2700 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18f09f37-8a95-4166-9a2c-5ab094589781@linux.ibm.com>
Date: Fri, 16 Feb 2024 13:18:30 -0600
From: Eddie James <eajames@...ux.ibm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-fsi@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        andi.shyti@...nel.org, alistair@...ple.id.au, joel@....id.au,
        jk@...abs.org, sboyd@...nel.org, mturquette@...libre.com,
        robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org
Subject: Re: [PATCH 10/33] fsi: aspeed: Add AST2700 support


On 2/16/24 02:09, Krzysztof Kozlowski wrote:
> On 15/02/2024 23:07, Eddie James wrote:
>> AST2700 requires a few bits set differently in the OPB retry
>> counter register, so add some match data and set the register
>> accordingly.
>>
>> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
>> ---
>>   drivers/fsi/fsi-master-aspeed.c | 28 +++++++++++++++++++++++++---
>
>> +
>>   static const struct of_device_id fsi_master_aspeed_match[] = {
>> -	{ .compatible = "aspeed,ast2600-fsi-master" },
>> +	{
>> +		.compatible = "aspeed,ast2600-fsi-master",
>> +		.data = &fsi_master_ast2600_data,
>> +	},
>> +	{
>> +		.compatible = "aspeed,ast2700-fsi-master",
> Undocumented. Really, you do not have checkpatch in IBM?
>
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.


I ran checkpatch. There are several FSI drivers with undocumented 
compatible strings, and the Aspeed master documentation isn't in yaml 
format, so that would require an update too. Therefore I ignored the 
warning - my mistake. I will document it in v2.


>
>
> Best regards,
> Krzysztof
>