[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8d68a49a35799d1686d9b674ce4edfd91c68850b.camel@ndufresne.ca>
Date: Fri, 16 Feb 2024 14:29:55 -0500
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Shreeya Patel
<shreeya.patel@...labora.com>, heiko@...ech.de, mchehab@...nel.org,
robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
mturquette@...libre.com, sboyd@...nel.org, p.zabel@...gutronix.de,
jose.abreu@...opsys.com, nelson.costa@...opsys.com,
dmitry.osipenko@...labora.com, sebastian.reichel@...labora.com,
shawn.wen@...k-chips.com
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
linux-clk@...r.kernel.org, linux-dt@...r.kernel.org,
linux-arm@...ts.infradead.org
Subject: Re: [PATCH 1/4] clk: rockchip: rst-rk3588: Add BIU reset
Le vendredi 16 février 2024 à 11:03 +0100, Krzysztof Kozlowski a écrit :
> On 16/02/2024 10:49, Shreeya Patel wrote:
> > Export hdmirx_biu soft reset id which is required by the hdmirx controller.
> >
> > Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com>
> > ---
> > drivers/clk/rockchip/rst-rk3588.c | 1 +
> > include/dt-bindings/reset/rockchip,rk3588-cru.h | 2 ++
>
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
>
> Please do internal review. The internal Collabora review would tell you:
> YOU MUST run checkpatch. Then you see errors, so why do you send patch
> with errors to the mailing list?
Mistakes helps you learn. Meanwhile, I've triggered our temporary CI which
hopefully will catch this and some more for a better v2. Shreeya, I don't think
this includes any DT automated checks, this is on you.
https://gitlab.collabora.com/linux/build-scripts/-/pipelines/85935
>
> Best regards,
> Krzysztof
>
>
Powered by blists - more mailing lists