linux-kernel - Re: [PATCH] media: dvb-frontends: avoid stack overflow warnings with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <025f63f5-9114-439b-ad49-c37dffd1ea2f@app.fastmail.com>
Date: Fri, 16 Feb 2024 21:11:25 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Justin Stitt" <justinstitt@...gle.com>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Hans Verkuil" <hverkuil-cisco@...all.nl>,
 "laurent.pinchart" <Laurent.pinchart@...asonboard.com>,
 "Nathan Chancellor" <nathan@...nel.org>,
 "Nick Desaulniers" <ndesaulniers@...gle.com>,
 "Bill Wendling" <morbo@...gle.com>, "Mark Brown" <broonie@...nel.org>,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH] media: dvb-frontends: avoid stack overflow warnings with clang

On Fri, Feb 16, 2024, at 19:56, Justin Stitt wrote:
> On Fri, Feb 16, 2024 at 8:32 AM Arnd Bergmann <arnd@...nel.org> wrote:
>> -
>> -       buf[0] = MSB(reg);
>> -       buf[1] = LSB(reg);
>> -       memcpy(buf + 2, data, len);
>
> I'm curious why a copy was made at all.
>
> Reviewed-by: Justin Stitt <justinstitt@...gle.com>

I guess the idea was to allow writing arbitrarily long
contents to a single register with a single decriptor.

The current version of the driver only ever writes a single
byte value, but maybe it either used to have other writes,
or it was meant to support them later but never did.

      Arnd