linux-kernel - Re: [PATCH v5 4/4] riscv/barrier: Resolve checkpatch.pl error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zc/OGnjVKcCuKNA5@andrea>
Date: Fri, 16 Feb 2024 22:05:30 +0100
From: Andrea Parri <parri.andrea@...il.com>
To: Eric Chan <ericchancf@...gle.com>
Cc: paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/4] riscv/barrier: Resolve checkpatch.pl error

On Tue, Feb 13, 2024 at 10:40:00PM +0000, Eric Chan wrote:
> The past form of RISCV_FENCE would cause checkpatch.pl to issue
> error messages, the example is as follows:
> ERROR: space required after that ',' (ctx:VxV)
> +#define __atomic_acquire_fence()       RISCV_FENCE(r,rw)

Not the "best" example, according to Samuel's feedback and the diff
below.  How about something like:

ERROR: space required after that ',' (ctx:VxV)
#10: FILE: arch/riscv/include/asm/barrier.h:28:
+#define __smp_mb()	RISCV_FENCE(rw,rw)


> -#define __mb()		RISCV_FENCE(iorw,iorw)
> -#define __rmb()		RISCV_FENCE(ir,ir)
> -#define __wmb()		RISCV_FENCE(ow,ow)
> +#define __mb()		RISCV_FENCE(iorw, iorw)
> +#define __rmb()		RISCV_FENCE(ir, ir)
> +#define __wmb()		RISCV_FENCE(ow, ow)

This would go away per my comment to 1/4.


>From a less technical viewpoint and FYI, an unwritten rule of "working
with the Linux kernel community" is:

  Don't forget to keep people who spent time reviewing, or providing
  feedback to, your patch in the loop/in Cc: in your next iterations;
  they might be the only people who will be able to provide feedback
  /suggestions/help in your future life.

;-)

  Andrea