linux-kernel - [PATCH v2 2/2] leds: expresswire: don't depend on NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240216-expresswire-deps-v2-2-8be59c4a75f5@skole.hr>
Date: Fri, 16 Feb 2024 22:15:44 +0100
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, 
 Daniel Thompson <daniel.thompson@...aro.org>, 
 Linus Walleij <linus.walleij@...aro.org>, Arnd Bergmann <arnd@...db.de>
Cc: Flavio Suligoi <f.suligoi@...m.it>, Hans de Goede <hdegoede@...hat.com>, 
 Jianhua Lu <lujianhua000@...il.com>, 
 "Matthew Wilcox (Oracle)" <willy@...radead.org>, 
 Helge Deller <deller@....de>, Jingoo Han <jingoohan1@...il.com>, 
 Karel Balej <balejk@...fyz.cz>, dri-devel@...ts.freedesktop.org, 
 linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-leds@...r.kernel.org, 
 Duje Mihanović <duje.mihanovic@...le.hr>, 
 kernel test robot <lkp@...el.com>
Subject: [PATCH v2 2/2] leds: expresswire: don't depend on NEW_LEDS

The ExpressWire library does not depend on NEW_LEDS and selecting it
from a subsystem other than LEDs may cause Kconfig warnings:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
  Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y]
  Selected by [y]:
  - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y]

Move it out of the "if NEW_LEDS" block to allow selection from other
subsystems (in particular backlight) without raising this warning.

Reported-by: Arnd Bergmann <arnd@...db.de>
Closes: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402161410.IG9I4odj-lkp@intel.com/
Suggested-by: Daniel Thompson <daniel.thompson@...aro.org>
Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library")
Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>
Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
---
Changes in v2:
- Change Link: to Closes: to silence checkpatch
- Add kernel test robot's error report
---
 drivers/leds/Kconfig | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 52328d295b4e..66998b938ed3 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -6,6 +6,12 @@ config LEDS_GPIO_REGISTER
 	  As this function is used by arch code it must not be compiled as a
 	  module.
 
+# This library does not depend on NEW_LEDS and must be independent so it can be
+# selected from other subsystems (specifically backlight).
+config LEDS_EXPRESSWIRE
+	bool
+	depends on GPIOLIB
+
 menuconfig NEW_LEDS
 	bool "LED Support"
 	help
@@ -186,10 +192,6 @@ config LEDS_EL15203000
 	  To compile this driver as a module, choose M here: the module
 	  will be called leds-el15203000.
 
-config LEDS_EXPRESSWIRE
-	bool
-	depends on GPIOLIB
-
 config LEDS_TURRIS_OMNIA
 	tristate "LED support for CZ.NIC's Turris Omnia"
 	depends on LEDS_CLASS_MULTICOLOR

-- 
2.43.1