linux-kernel - Re: [PATCH v2 1/6] mm/migrate: introduce migrate_pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10f2de59-5ef3-9bc0-b359-e0e8474ab92b@oracle.com>
Date: Fri, 16 Feb 2024 14:03:49 -0800
From: Sidhartha Kumar <sidhartha.kumar@...cle.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, apopple@...dia.com
Subject: Re: [PATCH v2 1/6] mm/migrate: introduce migrate_pfn_to_folio()

On 2/16/24 1:50 PM, Matthew Wilcox wrote:
> On Fri, Feb 16, 2024 at 01:13:15PM -0800, Sidhartha Kumar wrote:
>> +static inline struct folio *migrate_pfn_to_folio(unsigned long mpfn)
>> +{
>> +	return page_folio(migrate_pfn_to_page(mpfn));
> 
> umm, no.
> 
> 	struct page *page = migrate_pfn_to_page(mpfn);
> 	if (page)
> 		return page_folio(page);
> 	return NULL;

Thanks, I overlooked checking for NULL before converting the page to a folio. 
I'll make this change for v3.