linux-kernel - Re: [RFC PATCH 4/8] thp: Add thp_get_unmapped_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbc567bd38931a1fba6009c97ec935fabe15a01a.camel@intel.com>
Date: Fri, 16 Feb 2024 22:21:13 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>
CC: "debug@...osinc.com" <debug@...osinc.com>, "luto@...nel.org"
	<luto@...nel.org>, "x86@...nel.org" <x86@...nel.org>,
	"Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>, "broonie@...nel.org"
	<broonie@...nel.org>, "keescook@...omium.org" <keescook@...omium.org>,
	"bp@...en8.de" <bp@...en8.de>, "mingo@...hat.com" <mingo@...hat.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"peterz@...radead.org" <peterz@...radead.org>, "hpa@...or.com"
	<hpa@...or.com>, "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 4/8] thp: Add thp_get_unmapped_area_vmflags()

On Fri, 2024-02-16 at 14:59 +0200, Kirill A. Shutemov wrote:
> On Thu, Feb 15, 2024 at 03:13:28PM -0800, Rick Edgecombe wrote:
> > +unsigned long thp_get_unmapped_area(struct file *filp, unsigned
> > long addr,
> > +               unsigned long len, unsigned long pgoff, unsigned
> > long flags)
> > +{
> > +       return thp_get_unmapped_area_vmflags(filp, addr, len,
> > pgoff, flags, 0);
> >   }
> >   EXPORT_SYMBOL_GPL(thp_get_unmapped_area);
> 
> Again, static inline should be fine.

Not sure if the diff might be a bit misleading here, the signature of
thp_get_unmapped_area() didn't actually change.

If thp_get_unmapped_area() is made into a static inline, then
thp_get_unmapped_area_vmflags() would need to be exported instead so it
could be used in some modules. Unlike get_unmapped_area()
thp_get_unmapped_area is actually is used that way.

Better to export the more limited version?