linux-kernel - Re: [PATCH -next] spi: spi-summary.rst: fix underline length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 16 Feb 2024 11:12:35 +0530
From: Dhruva Gole <d-gole@...com>
To: Randy Dunlap <rdunlap@...radead.org>
CC: <linux-kernel@...r.kernel.org>, Mark Brown <broonie@...nel.org>,
        <linux-spi@...r.kernel.org>
Subject: Re: [PATCH -next] spi: spi-summary.rst: fix underline length

Hi,

On Feb 15, 2024 at 21:16:37 -0800, Randy Dunlap wrote:
> The change to use "target" requires an underline to be extended by
> one more character to fix a documentation build warning:
> 
>   Documentation/spi/spi-summary.rst:274: WARNING: Title underline too short.
>   Declare target Devices
>   ^^^^^^^^^^^^^^^^^^^^^

Oops, looks like I missed it.

> 
> Fixes: hash ("spi: Update the "master/slave" terminology in documentation")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Dhruva Gole <d-gole@...com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: linux-spi@...r.kernel.org
> ---
>  Documentation/spi/spi-summary.rst |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/Documentation/spi/spi-summary.rst b/Documentation/spi/spi-summary.rst
> --- a/Documentation/spi/spi-summary.rst
> +++ b/Documentation/spi/spi-summary.rst
> @@ -271,7 +271,7 @@ an external clock, where another derives
>  settings of some master clock.
>  
>  Declare target Devices
> -^^^^^^^^^^^^^^^^^^^^^
> +^^^^^^^^^^^^^^^^^^^^^^

Good catch,
Reviewed-by: Dhruva Gole <d-gole@...com>

Mark,
Will you be just squashing the commits since they're still in next
or will this be a separate commit? Just curious how fixes work while
they're still not in any mainline linux tree

-- 
Best regards,
Dhruva Gole <d-gole@...com>