linux-kernel - Re: [PATCH] Fixed case issue with 'fault-injection' in documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 16 Feb 2024 07:19:23 +0100
From: Lukas Bulwahn <lukas.bulwahn@...il.com>
To: "Ran.Park" <ranpark@...mail.com>
Cc: ricardo@...liere.net, akinobu.mita@...il.com, corbet@....net, 
	linux-doc@...r.kernel.org, linux-kernel-mentees@...ts.linuxfoundation.org, 
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] Fixed case issue with 'fault-injection' in documentation

On Fri, Feb 16, 2024 at 6:29 AM Ran.Park <ranpark@...mail.com> wrote:
>
> Thank you for your reply. I'm sorry that I noticed this problem
> while browsing the document. I have not seen any report about this problem
> on lore.kernel.org or other places. Should I mention the situation elsewhere
> and then resend the patch to mention and fix the problem.
>

Ran, in the future: please do not remove the context when you reply to
somebody's email.

In this case, I wanted to help you to understand what Ricardo was
asking, but his original response was not in your email. So, I copy
and pasted it now---but that is not how it is supposed to be for
someone replying to your email.

On Wed, Feb 14, 2024 at 2:21 PM Ricardo B. Marliere
<ricardo@...liere.net> wrote:
>
> Hi Ran,
>
> On 14 Feb 19:40, Ran.Park wrote:
> > In the 'fault-injection' subdirectory, the first letter F
> > is capitalized, whereas in index.rst f is lowercase, but in
> > index.rst all other elements in the same column are capitalized.
>
> Does this fix any error or build warning? If so, it should be mentioned.
>

Ricardo suggests that:

- you run 'make htmldocs' before applying the patch and check for the
existing warnings.

- you run 'make cleandocs' and 'make htmldocs' after applying the
patch and check for the existing warnings.

Did any warning disappear or appear due to your patch? Were you
motivated by a specific warning you observed during the build and you
addressing that?

So, for starters: did you already try 'make htmldocs' with your patch
applied? What did you observe?


Lukas