linux-kernel - Re: [PATCH] clk: constify the of_phandle_args argument of of_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02461595-16b3-4fea-a029-54190e10e6f5@linaro.org>
Date: Fri, 16 Feb 2024 08:12:29 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Stephen Boyd <sboyd@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Jaroslav Kysela <perex@...ex.cz>, Jonathan Hunter <jonathanh@...dia.com>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Linus Walleij <linus.walleij@...aro.org>, Mark Brown <broonie@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Michael Turquette <mturquette@...libre.com>,
 NXP Linux Team <linux-imx@....com>, Nishanth Menon <nm@...com>,
 Peng Fan <peng.fan@....com>, Russell King <linux@...linux.org.uk>,
 Shawn Guo <shawnguo@...nel.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Sudeep Holla <sudeep.holla@....com>, Takashi Iwai <tiwai@...e.com>,
 Thierry Reding <thierry.reding@...il.com>, Vinod Koul <vkoul@...nel.org>,
 alsa-devel@...a-project.org, linux-amlogic@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, linux-omap@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-tegra@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] clk: constify the of_phandle_args argument of
 of_clk_provider

On 16/02/2024 00:12, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2024-02-08 08:37:10)
>> None of the implementations of the get() and get_hw() callbacks of
>> "struct of_clk_provider" modify the contents of received of_phandle_args
>> pointer.  They treat it as read-only variable used to find the clock to
>> return.  Make obvious that implementations are not supposed to modify
>> the of_phandle_args, by making it a pointer to const.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
> 
> This will almost certainly break the build once it is merged to
> linux-next. What's your plan to merge this?

First problem is that it might not apply... I prepared it on next to be
sure all subsystems are updated.

The idea is to get reviews and acks and then:
1. Maybe it applies cleanly to your tree meaning there will be no
conflicts with other trees,
2. If not, then I can keep rebasing it and it should be applied after rc1.



Best regards,
Krzysztof