linux-kernel - Re: [PATCH v3 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 16 Feb 2024 08:56:09 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Mihai.Sain@...rochip.com
Cc: conor@...nel.org, claudiu.beznea@...on.dev, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	Nicolas.Ferre@...rochip.com, andre.przywara@....com,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Cristian.Birsan@...rochip.com
Subject: Re: [PATCH v3 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node

On 16/02/2024 06:58:10+0000, Mihai.Sain@...rochip.com wrote:
> > diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > index 269e0a3ca269..c030b318985a 100644
> > --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > @@ -958,6 +958,30 @@ i2c9: i2c@600 {
> >  			};
> >  		};
> >  
> > +		flx10: flexcom@...20000 {
> > +			compatible = "atmel,sama5d2-flexcom";
> 
> My comment here was ignored:
> https://lore.kernel.org/all/20240214-robe-pregnancy-a1b056c9fe14@spud/
> 
> The SAMA7G5 has the same flexcom controller as SAMA5D2 MPU.
> 

Still, it needs its own compatible plus a fallback to
atmel,sama5d2-flexcom

> https://github.com/torvalds/linux/blob/master/drivers/mfd/atmel-flexcom.c#L83
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt#L8

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com