linux-kernel - Re: Re: [PATCH] USBIP: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240216075711.6752-2-pairmanxlr@gmail.com>
Date: Fri, 16 Feb 2024 15:55:23 +0800
From: Pairman Guo <pairmanxlr@...il.com>
To: gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org,
	pairmanxlr@...il.com,
	shuah@...nel.org,
	valentina.manea.m@...il.com
Subject: Re: Re: [PATCH] USBIP: Use fallthrough pseudo-keyword

On Thu, Feb 15, 2024 at 11:14:49 +0800, Greg KH wrote:
> This is not needed in a changelog text.

Thanks for telling. I'm new to lkml and still learning about the format.

> >  tools/usb/usbip/src/usbip.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
> > index f7c7220d9..ddcafb5c7 100644
> > --- a/tools/usb/usbip/src/usbip.c
> > +++ b/tools/usb/usbip/src/usbip.c
> > @@ -165,7 +165,7 @@ int main(int argc, char *argv[])
> >  		case '?':
> >  			printf("usbip: invalid option\n");
> >  			/* Terminate after printing error */
> > -			/* FALLTHRU */
> > +			fallthrough;
> 
> Did you compile this?  This is userspace code, and as-such, I don't
> think it has this keyword, does it?

I'm sorry for my hurrying. I ran ``make tools/usb`` with no warning or error,
so I sent this patch. Now it turns out ``make tools/usb`` doesn't cover
tools/usb/usbip. I tried again with ``./autogen.sh && ./configure && make``
and it indeed failed. Since usbip.c doesn't have any reference to
include/linux/compiler.h, it cannot use ``fallthrough``. Thanks again for
pointing out this error.

Thanks,

Pairman