linux-kernel - Re: [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36f99696-d7ca-4390-a263-dbb72d5c9ae6@intel.com>
Date: Fri, 16 Feb 2024 10:28:28 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Elad Nachman <enachman@...vell.com>, Ulf Hansson <ulf.hansson@...aro.org>
Cc: "huziji@...vell.com" <huziji@...vell.com>,
 "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues

On 15/02/24 19:01, Elad Nachman wrote:
> 
> 
>> -----Original Message-----
>> From: Ulf Hansson <ulf.hansson@...aro.org>
>> Sent: Thursday, February 15, 2024 6:51 PM
>> To: Elad Nachman <enachman@...vell.com>
>> Cc: huziji@...vell.com; adrian.hunter@...el.com; linux-
>> mmc@...r.kernel.org; linux-kernel@...r.kernel.org
>> Subject: [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On Thu, 15 Feb 2024 at 17:16, Elad Nachman <enachman@...vell.com>
>> wrote:
>>>
>>> From: Elad Nachman <enachman@...vell.com>
>>>
>>> Fix PHY init timeout issues:
>>>
>>> 1. Clock Stability issue causing PHY timeout
>>>
>>> 2. Timeout taking longer than needed on AC5X.
>>>    Solve by constantly testing the PHY init bit
>>>    until it toggles, but up to 100X timeout factor.
>>>
>>> v2:
>>>     1) convert polling loop to read_poll_timeout()
>>>        for both patches.
>>>
>>> Elad Nachman (2):
>>>   mmc: xenon: fix PHY init clock stability
>>>   mmc: xenon: add timeout for PHY init complete
>>>
>>>  drivers/mmc/host/sdhci-xenon-phy.c | 48
>>> ++++++++++++++++++++++++------
>>>  1 file changed, 39 insertions(+), 9 deletions(-)
>>>
>>
>> The series looks good to me. Although, I assume we should tag this for stable
>> kernels too and possibly add a fixes tag?
> 
> No problem.

Presumably:

Fixes: 06c8b667ff5b ("mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC")

FWIW:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> 
>>
>> Moreover, it would be nice to get an ack from Hu Ziji.
> 
> He does not longer work with Marvell, so this email is invalid, I tried also to send an e-mail manually as well and got:
> huziji@...vell.com
> Remote Server returned '550 5.1.1 RESOLVER.ADR.RecipNotFound; not found'
> 
> Could not locate him via google search either.
> 
>>
>> Kind regards
>> Uffe