[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240216174226.455472a436b40bbf2fd4ee4b@kernel.org>
Date: Fri, 16 Feb 2024 17:42:26 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Florent Revest
<revest@...omium.org>, linux-trace-kernel@...r.kernel.org, LKML
<linux-kernel@...r.kernel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
bpf <bpf@...r.kernel.org>, Sven Schnelle <svens@...ux.ibm.com>, Alexei
Starovoitov <ast@...nel.org>, Jiri Olsa <jolsa@...nel.org>, Arnaldo
Carvalho de Melo <acme@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
Alan Maguire <alan.maguire@...cle.com>, Mark Rutland
<mark.rutland@....com>, Peter Zijlstra <peterz@...radead.org>, Thomas
Gleixner <tglx@...utronix.de>, Guo Ren <guoren@...nel.org>
Subject: Re: [PATCH v7 23/36] function_graph: Add a new exit handler with
parent_ip and ftrace_regs
On Thu, 15 Feb 2024 10:39:43 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:
> On Wed, 7 Feb 2024 00:11:44 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> >
> > Add a new return handler to fgraph_ops as 'retregfunc' which takes
> > parent_ip and ftrace_regs instead of ftrace_graph_ret. This handler
> > is available only if the arch support CONFIG_HAVE_FUNCTION_GRAPH_FREGS.
> > Note that the 'retfunc' and 'reregfunc' are mutual exclusive.
> > You can set only one of them.
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> >
>
> > @@ -1076,6 +1083,7 @@ struct fgraph_ops {
> > trace_func_graph_ent_t entryfunc;
> > trace_func_graph_ret_t retfunc;
> > trace_func_graph_regs_ent_t entryregfunc;
> > + trace_func_graph_regs_ret_t retregfunc;
>
> Same for this:
>
> struct fgraph_ops {
> union {
> trace_func_graph_ent_t entryfunc;
> trace_func_graph_regs_ent_t entryregfunc;
> };
> union {
> trace_func_graph_ret_t retfunc;
> trace_func_graph_regs_ret_t retregfunc;
> }
OK, and we need to introduce a flag for fgraph_ops that it is using
`regfunc` or not.
Thank you,
>
> -- Steve
>
>
> > struct ftrace_ops ops; /* for the hash lists */
> > void *private;
> > int idx;
--
Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists