[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e491ec4a-f79b-4063-bd24-bbf3644ce486@quicinc.com>
Date: Fri, 16 Feb 2024 16:48:31 +0530
From: Jishnu Prakash <quic_jprakash@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <jic23@...nel.org>,
<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
<conor+dt@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <lee@...nel.org>,
<andriy.shevchenko@...ux.intel.com>, <daniel.lezcano@...aro.org>,
<lars@...afoo.de>, <luca@...tu.xyz>, <marijn.suijten@...ainline.org>,
<agross@...nel.org>, <sboyd@...nel.org>, <rafael@...nel.org>,
<rui.zhang@...el.com>, <lukasz.luba@....com>,
<linus.walleij@...aro.org>, <quic_subbaram@...cinc.com>,
<quic_collinsd@...cinc.com>, <quic_amelende@...cinc.com>,
<quic_kamalw@...cinc.com>, <kernel@...cinc.com>,
<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-arm-msm-owner@...r.kernel.org>, <linux-iio@...r.kernel.org>,
<linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<cros-qcom-dts-watchers@...omium.org>
Subject: Re: [PATCH v3 2/3] dt-bindings: iio: adc: Add support for QCOM PMIC5
Gen3 ADC
Hi Dmitry,
On 2/16/2024 4:18 PM, Dmitry Baryshkov wrote:
> Hi Jishnu,
>
>
> On Fri, 16 Feb 2024 at 12:39, Jishnu Prakash <quic_jprakash@...cinc.com> wrote:
>
> Please disable sending HTML emails in your email client. It is
> generally frowned upon, it complicates replying, it breaks quotations,
> etc.
Sorry, I'm not sure how that happened, but I have fixed it now.
>
>>
>> Hi Krzysztof,
>>
>> On 1/4/2024 1:48 PM, Krzysztof Kozlowski wrote:
>>
>> On 31/12/2023 18:12, Jishnu Prakash wrote:
>>
>> For the PMIC5-Gen3 type PMICs, ADC peripheral is present in HW for the
>> following PMICs: PMK8550, PM8550, PM8550B and PM8550VX PMICs.
>>
>> +
>>
>> + qcom,adc-tm:
>> + description: |
>> + Indicates if ADC_TM monitoring is done on this channel.
>> + Defined for compatible property "qcom,spmi-adc5-gen3".
>
> You are describing qcom,spmi-adc5-gen3, are you not? So this phrase
> adds nothing.
Yes, I'll remove this.
>
>> + This is the same functionality as in the existing QCOM ADC_TM
>> + device, documented at devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml.
>> + type: boolean
>> +
>>
>> Why do you duplicate entire vadc file? Why it cannot be part of that
>> file? Oh wait, it was in v2.
>>
>> You now duplicated a lot of property definitions without clear reason.
>> If this is intention, then you need to put them in common schema.
>>
>>
>> Many of the properties used for earlier QCOM VADC devices will be used for this device too.....do you mean I can add a new schema file (named something like qcom,vadc.yaml) and move common properties into it (like qcom,hw-settle-time, qcom,decimation, etc) from this file and qcom,spmi-vadc.yaml?
>>
>> Can I do it in the same patch or should it be a separate patch coming before this one ?
>
> I'd say, separate patch. Move first, extend later.
OK, I'll make it this way if no one else has any objections.
Thanks,
Jishnu
>
>>
>>
>>
Powered by blists - more mailing lists