linux-kernel - Re: [PATCH] clk: constify the of_phandle_args argument of of_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 16 Feb 2024 12:46:48 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Sudeep Holla <sudeep.holla@....com>, Peng Fan <peng.fan@....com>, Shawn Guo <shawnguo@...nel.org>, 
	Nishanth Menon <nm@...com>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, Thierry Reding <thierry.reding@...il.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Vinod Koul <vkoul@...nel.org>, 
	Russell King <linux@...linux.org.uk>, 
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Mark Brown <broonie@...nel.org>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, linux-clk@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	patches@...nsource.cirrus.com, linux-stm32@...md-mailman.stormreply.com, 
	NXP Linux Team <linux-imx@....com>, linux-amlogic@...ts.infradead.org, 
	linux-arm-msm@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-phy@...ts.infradead.org, 
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH] clk: constify the of_phandle_args argument of of_clk_provider

On Thu, Feb 8, 2024 at 5:37 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> None of the implementations of the get() and get_hw() callbacks of
> "struct of_clk_provider" modify the contents of received of_phandle_args
> pointer.  They treat it as read-only variable used to find the clock to
> return.  Make obvious that implementations are not supposed to modify
> the of_phandle_args, by making it a pointer to const.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

>  drivers/clk/renesas/r9a06g032-clocks.c        |  2 +-
>  drivers/clk/renesas/renesas-cpg-mssr.c        |  2 +-
>  drivers/clk/renesas/rzg2l-cpg.c               |  2 +-

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds