linux-kernel - RE: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA0PR12MB8906755426577E8496BA65B3B54C2@IA0PR12MB8906.namprd12.prod.outlook.com>
Date: Fri, 16 Feb 2024 12:35:04 +0000
From: Petlozu Pravareshwar <petlozup@...dia.com>
To: Thierry Reding <thierry.reding@...il.com>, Jon Hunter
	<jonathanh@...dia.com>, Prathamesh Shete <pshete@...dia.com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"dmitry.osipenko@...labora.com" <dmitry.osipenko@...labora.com>,
	"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>, Kartik Rajput
	<kkartik@...dia.com>, "cai.huoqing@...ux.dev" <cai.huoqing@...ux.dev>,
	Sandipan Patra <spatra@...dia.com>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234

> On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> > From: Prathamesh Shete <pshete@...dia.com>
> >
> > Add SD wake event for Tegra234 so that system can be woken up from
> > suspend when SD card hot-plug/unplug event is detected.
> >
> > Signed-off-by: Prathamesh Shete <pshete@...dia.com>
> > Signed-off-by: Petlozu Pravareshwar <petlozup@...dia.com>
> > ---
> >  drivers/soc/tegra/pmc.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index
> > 6dfcc7f50ece..dc4eab3191c2 100644
> > --- a/drivers/soc/tegra/pmc.c
> > +++ b/drivers/soc/tegra/pmc.c
> > @@ -3,7 +3,7 @@
> >   * drivers/soc/tegra/pmc.c
> >   *
> >   * Copyright (c) 2010 Google, Inc
> > - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> > + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> >   *
> >   * Author:
> >   *	Colin Cross <ccross@...gle.com>
> > @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event
> tegra234_wake_events[] = {
> >  	TEGRA_WAKE_IRQ("pmu", 24, 209),
> >  	TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> >  	TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> > +	TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
> 
> I'd prefer to stick with - instead of _ in these names, like we do with sw-wake.
> No need to resend, I can make that change when applying, provided you
> don't have any objections.
> 
Yes, let's stick with - only instead of _ in the names for consistency.
Thanks.
 
> Thierry
> 
> >  	TEGRA_WAKE_IRQ("rtc", 73, 10),
> >  	TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179),  };