linux-kernel - Re: [PATCH] parisc/kprobes: always include asm-generic/kprobes.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a0a120e-ac4d-4c1a-a22f-1b0800ecb973@gmx.de>
Date: Fri, 16 Feb 2024 14:29:33 +0100
From: Helge Deller <deller@....de>
To: Max Kellermann <max.kellermann@...os.com>, svens@...ckframe.org,
 James.Bottomley@...senPartnership.com, mcgrof@...nel.org,
 linux-parisc@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc/kprobes: always include asm-generic/kprobes.h

On 2/12/24 00:09, Max Kellermann wrote:
> The NOKPROBE_SYMBOL macro (and others) were moved to
> asm-generic/kprobes.h in 2017 by commit 7d134b2ce639 ("kprobes: move
> kprobe declarations to asm-generic/kprobes.h"), and this new header
> was included by asm/kprobes.h unconditionally on all architectures.
>
> When kprobe support was added to parisc in 2017 by commit
> 8858ac8e9e9b1 ("parisc: Implement kprobes"), that header was only
> included when CONFIG_KPROBES was enabled.
>
> This can lead to build failures when NOKPROBE_SYMBOL is used, but
> CONFIG_KPROBES is disabled.  This mistake however was never actually
> noticed because linux/kprobes.h also includes asm-generic/kprobes.h
> (though I do not understand why that is, because it also includes
> asm/kprobes.h).
>
> To prevent eventual build failures, I suggest to always include
> asm-generic/kprobes.h on parisc, just like all the other architectures
> do.  This way, including asm/kprobes.h suffices, and nobody (outside
> of arch/) ever needs to explicitly include asm-generic/kprobes.h.
>
> Signed-off-by: Max Kellermann <max.kellermann@...os.com>

applied to parisc git tree.

Thanks!
Helge


> ---
>   arch/parisc/include/asm/kprobes.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/parisc/include/asm/kprobes.h b/arch/parisc/include/asm/kprobes.h
> index 0a175ac87698..0f42f5c8e3b6 100644
> --- a/arch/parisc/include/asm/kprobes.h
> +++ b/arch/parisc/include/asm/kprobes.h
> @@ -10,9 +10,10 @@
>   #ifndef _PARISC_KPROBES_H
>   #define _PARISC_KPROBES_H
>
> +#include <asm-generic/kprobes.h>
> +
>   #ifdef CONFIG_KPROBES
>
> -#include <asm-generic/kprobes.h>
>   #include <linux/types.h>
>   #include <linux/ptrace.h>
>   #include <linux/notifier.h>