linux-kernel - Re: [PATCH v4 0/3] iio: humidity: hdc3020: add threshold events support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 16 Feb 2024 13:17:21 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Li peiyu <579lpy@...il.com>, Nuno
 Sa <nuno.sa@...log.com>, Javier Carrasco <javier.carrasco.cruz@...il.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/3] iio: humidity: hdc3020: add threshold events
 support

On Wed, 14 Feb 2024 09:53:42 +0100
Dimitri Fedrau <dima.fedrau@...il.com> wrote:

> Based on Fix:
> a69eeaad093d "iio: humidity: hdc3020: fix temperature offset" in branch
> fixes-togreg

This applies fine independent of that (they will meet each other upstream!)
so I'll take this via my tree now rather than waiting to get that dependency
after a pull request  / rebase.  It will also actually get built in next
where the missing Kconfig / Makefile fix is in place.

Applied to the togreg branch of iio.git. Normally I'd push it out as testing but
given I haven't yet queued anything up today and this won't get built
until it hits next I've pushed it out as togreg directly after a quick local
build test.

Thanks,

Jonathan

> 
> Changes in V2:
>   - Fix alphabetical order of includes(Christophe)
>   - Fix typo: change varibale name "HDC3020_R_R_RH_THRESH_LOW_CLR" to
>     HDC3020_R_T_RH_THRESH_LOW_CLR to match variable name pattern(Christophe)
>   - Add constants HDC3020_MIN_TEMP and HDC3020_MAX_TEMP for min/max threshold
>     inputs (Christophe)
>   - Change HDC3020_MIN_TEMP to -40, as stated in the datasheet(Javier)
> 
> Changes in V3:
>   - drop u8 register pairs and switch to 16bit defines(Jonathan)
>   - create helper functions to avoid code duplication(Jonathan)
>   - Add interrupt bindings in example
>   - use the decimal part for setting thresholds(Javier)
>   - use return in switch cases hdc3020_read_thresh(Jonathan)
>   - fix interrupt handler:(Jonathan)
>     - return IRQ_HANDLED when we get a read back failure
>     - take the timestamp into a local variable
>   - fix multiline comments(Jonathan)
>   - use fixed value "hdc3020" instead of dev_id in probe
>   - clear interrupt after registering the interrupt handler
>   - remove interrupt polarity
> 
> Changes in V4:
>   - fix commit message of patch "iio: humidity: hdc3020: switch to 16bit
>     register defines". (Jonathan)
>   - add missing include in bindings example. (Javier, Rob)
>   - added copyright information
> 
> Dimitri Fedrau (3):
>   iio: humidity: hdc3020: switch to 16bit register defines
>   dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example
>   iio: humidity: hdc3020: add threshold events support
> 
>  .../bindings/iio/humidity/ti,hdc3020.yaml     |   3 +
>  drivers/iio/humidity/hdc3020.c                | 445 ++++++++++++------
>  2 files changed, 312 insertions(+), 136 deletions(-)
>