[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b11ec88e-5408-4bcc-9d93-942ad81eccde@linaro.org>
Date: Fri, 16 Feb 2024 14:37:19 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Abel Vesa <abel.vesa@...aro.org>, Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Johan Hovold <johan@...nel.org>
Cc: linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/2] phy: qcom: edp: Add set_mode op for configuring
eDP/DP submode
On 16.02.2024 14:02, Abel Vesa wrote:
> Future platforms should not use different compatibles to differentiate
> between eDP and DP mode. Instead, they should use a single compatible as
> the IP block is the same. It will be the job of the controller to set the
> submode of the PHY accordingly.
>
> The existing platforms will remain with separate compatibles for each
> mode.
>
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> ---
[...]
>
> +static int qcom_edp_phy_set_mode(struct phy *phy, enum phy_mode mode, int submode)
> +{
> + struct qcom_edp *edp = phy_get_drvdata(phy);
> +
> + if (mode != PHY_MODE_DP)
> + return -EINVAL;
> +
> + edp->is_edp = submode == PHY_SUBMODE_EDP ? true : false;
it's bool-converted even without the ternary operator
Konrad
Powered by blists - more mailing lists