linux-kernel - Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K dpi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 17 Feb 2024 09:13:50 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Vamsi Attunuru <vattunuru@...vell.com>
Cc: arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K dpi driver

On Fri, Feb 16, 2024 at 02:32:25AM -0800, Vamsi Attunuru wrote:
> Adds a driver for Marvell CN10K DPI(DMA Engine) device's physical function
> which initializes DPI DMA hardware's global configuration and enables
> hardware mailbox channels between physical function (PF) and it's virtual
> functions (VF). VF device drivers (User space drivers) use this hw mailbox
> to communicate any required device configuration on it's respective VF
> device. Accordingly, this DPI PF driver provision the VF device resources.
> 
> At the hardware level, the DPI physical function (PF) acts as a management
> interface to setup the VF device resources, VF devices are only provisioned
> to handle or control the actual DMA Engine's data transfer capabilities.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@...vell.com>
> ---
> 
> Changes V1 -> V2:
> - Fixed return values and busy-wait loops
> - Merged .h file into .c file
> - Fixed directory structure
> - Removed module params
> - Registered the device as misc device

Why register as a misc device if you don't actually use it at all?  That
feels pointless and extra code and confusion for everyone as you have
created a device node in the system that will just fail all operations
made on it.

confused,

greg k-h