linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: add common properties with label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85307d34-bb60-41ea-b478-c821dbd2b51b@roeck-us.net>
Date: Sat, 17 Feb 2024 07:30:35 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: add common properties with label

On 2/17/24 00:21, Krzysztof Kozlowski wrote:
> On 16/02/2024 18:11, Guenter Roeck wrote:
>> On 2/15/24 23:55, Krzysztof Kozlowski wrote:
>>> Linux hwmon core code parses "label" property for each device, so add a
>>> common schema for that.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>>   From hwmon perspective:
>>
>> Acked-by: Guenter Roeck <linux@...ck-us.net>
>>
>>> ---
>>>    .../devicetree/bindings/hwmon/hwmon-common.yaml          | 16 ++++++++++++++++
>>>    1 file changed, 16 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml
>>> new file mode 100644
>>> index 000000000000..d83f4180f622
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml
>>> @@ -0,0 +1,16 @@
>>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/hwmon/hwmon-common.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Hardware Monitoring Devices Common Properties
>>> +
>>> +maintainers:
>>> +  - Guenter Roeck <linux@...ck-us.net>
>>> +
>>> +properties:
>>> +  label:
>>> +    description: A descriptive name for this device.
>>> +
>>
>> Would it make sense to also add shunt-resistor-micro-ohms ?
> 
> It's not present on many devices, I think, so it is also not parsed by
> hwmon core. I plan to add above $ref to hwmon-common to each hwmon
> binding, so this would mean all of them will get shunt-resistor. I would
> not add it, but I also don't mind if I am overruled.
> 

No problem, I just don't know how such common rules are supposed
to be understood. Thanks a lot for the clarification.

Thanks,
Guenter