linux-kernel - Re: [PATCH] gpio: constify opaque pointer "data" in gpio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mc9vQwtV+Sa0aazq=A=z1FSbwK9rNayHM5Sr5Mt9oNOEw@mail.gmail.com>
Date: Sat, 17 Feb 2024 20:03:30 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: constify opaque pointer "data" in gpio_device_find()

On Fri, Feb 16, 2024 at 2:52 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> The opaque pointer "data" in each match function used by
> gpio_device_find() is a pointer to const, thus the same argument passed
> to gpio_device_find() can adjusted similarly.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/gpio/gpiolib.c      | 2 +-
>  include/linux/gpio/driver.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 0e332b24c7b8..8c9cb324b7a4 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1112,7 +1112,7 @@ EXPORT_SYMBOL_GPL(gpiochip_remove);
>   * If the function returns non-NULL, the returned reference must be freed by
>   * the caller using gpio_device_put().
>   */
> -struct gpio_device *gpio_device_find(void *data,
> +struct gpio_device *gpio_device_find(const void *data,
>                                      int (*match)(struct gpio_chip *gc,
>                                                   const void *data))
>  {
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index 51b23211794d..251a610f2234 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -628,7 +628,7 @@ int devm_gpiochip_add_data_with_key(struct device *dev, struct gpio_chip *gc,
>                                     void *data, struct lock_class_key *lock_key,
>                                     struct lock_class_key *request_key);
>
> -struct gpio_device *gpio_device_find(void *data,
> +struct gpio_device *gpio_device_find(const void *data,
>                                 int (*match)(struct gpio_chip *gc, const void *data));
>  struct gpio_device *gpio_device_find_by_label(const char *label);
>  struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode_handle *fwnode);
> --
> 2.34.1
>

Applied, thanks!

Bart