linux-kernel - Re: [RESEND PATCH] llist: Make llist_del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xymtdy5.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date: Sun, 18 Feb 2024 15:43:30 +0800
From: "Huang, Ying" <ying.huang@...el.com>
To: liqiang <liqiang64@...wei.com>
Cc: <akpm@...ux-foundation.org>,  <paulmck@...ux.vnet.ibm.com>,
  <neilb@...e.de>,  <chuck.lever@...cle.com>,
  <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] llist: Make llist_del_first return only the
 first node

liqiang <liqiang64@...wei.com> writes:

> Set the next of the returned node of llist_del_first
> to NULL, which can prevent subsequent nodes in llist
> from being exposed, and is more consistent with the
> logic of this interface.
>
> Signed-off-by: liqiang <liqiang64@...wei.com>
> ---
>  lib/llist.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/llist.c b/lib/llist.c
> index f21d0cf..c33fff5 100644
> --- a/lib/llist.c
> +++ b/lib/llist.c
> @@ -61,6 +61,7 @@ struct llist_node *llist_del_first(struct llist_head *head)
>  		next = READ_ONCE(entry->next);
>  	} while (!try_cmpxchg(&head->first, &entry, next));
>  
> +	entry->next = NULL;
>  	return entry;
>  }
>  EXPORT_SYMBOL_GPL(llist_del_first);

This isn't needed for functionality correctness.  Many users of llist
ask for performance.  So, it may be better to let the users to decide
whether to set entry->next to NULL.

--
Best Regards,
Huang, Ying