lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.22.394.2402180917060.3095@hadrien>
Date: Sun, 18 Feb 2024 09:17:52 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Li Zhijian <lizhijian@...itsu.com>
cc: linux-kernel@...r.kernel.org, Nicolas Palix <nicolas.palix@...g.fr>, 
    cocci@...ia.fr
Subject: Re: [PATCH v2] coccinelle: device_attr_show: Remove useless expression
 STR



On Sun, 18 Feb 2024, Li Zhijian wrote:

> Commit ff82e84e80fc ("coccinelle: device_attr_show: simplify patch case")
> simplifies the patch case, as a result, STR is no longer needed.
>
> This also helps to fix below coccicheck warning:
> > warning: rp: metavariable STR not used in the - or context code
>
> CC: Julia Lawall <Julia.Lawall@...ia.fr>
> CC: Nicolas Palix <nicolas.palix@...g.fr>
> CC: cocci@...ia.fr
> Fixes: ff82e84e80fc ("coccinelle: device_attr_show: simplify patch case")
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>

Applied to my tree

> ---
>  scripts/coccinelle/api/device_attr_show.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/api/device_attr_show.cocci b/scripts/coccinelle/api/device_attr_show.cocci
> index 550d1d2fc02a..dfcf9304195f 100644
> --- a/scripts/coccinelle/api/device_attr_show.cocci
> +++ b/scripts/coccinelle/api/device_attr_show.cocci
> @@ -28,7 +28,7 @@ ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
>
>  @rp depends on patch@
>  identifier show, dev, attr, buf;
> -expression BUF, SZ, FORMAT, STR;
> +expression BUF, SZ, FORMAT;
>  @@
>
>  ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
> --
> 2.29.2
>
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ