linux-kernel - [PATCH v2 0/2] AMD PMF Smart PC error handling cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240217014107.113749-1-mario.limonciello@amd.com>
Date: Fri, 16 Feb 2024 19:41:05 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: <Shyam-sundar.S-k@....com>, <hdegoede@...hat.com>
CC: <platform-driver-x86@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Mario Limonciello <mario.limonciello@....com>
Subject: [PATCH v2 0/2] AMD PMF Smart PC error handling cleanups

While debugging the suspend issue for amd-pmf the initial bisect result
pointed at red herrings of cleanup flow problems for
amd_pmf_init_smart_pc().  The actual issue wasn't in this code, but still
a lot of memory is allocated and not immediately released if any of the
error branches are taken.

This series cleans that up so that every step is cleaned up. I believe
this actually fixes driver bugs that "could" occur if a BIOS advertisd
Smart PC as well as ITS auto or CNQF but didn't include a policy in the
BIOS.

Mario Limonciello (2):
  platform/x86/amd/pmf: Add debugging message for missing policy data
  platform/x86/amd/pmf: Fixup error handling for amd_pmf_init_smart_pc()

 drivers/platform/x86/amd/pmf/tee-if.c | 69 +++++++++++++++++----------
 1 file changed, 43 insertions(+), 26 deletions(-)

-- 
2.34.1