linux-kernel - Re: [PATCH AUTOSEL 6.1 23/28] PCI: dwc: Clean up dw_pcie_ep_raise_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdJF4fpSn/0goBqb@duo.ucw.cz>
Date: Sun, 18 Feb 2024 19:01:05 +0100
From: Pavel Machek <pavel@....cz>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Niklas Cassel <cassel@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	jingoohan1@...il.com, gustavo.pimentel@...opsys.com,
	lpieralisi@...nel.org, kw@...ux.com, linux-pci@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 23/28] PCI: dwc: Clean up
 dw_pcie_ep_raise_msi_irq() alignment

Hi!

> From: Dan Carpenter <dan.carpenter@...aro.org>
> 
> [ Upstream commit 67057f48df79a3d73683385f521215146861684b ]
> 
> I recently changed the alignment code in dw_pcie_ep_raise_msix_irq().  The
> code in dw_pcie_ep_raise_msi_irq() is similar, so update it to match, just
> for consistency.  (No effect on runtime, just a cleanup).

Just a cleanup, we don't need it in stable.

Best regards,
									Pavel
									
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -528,9 +528,10 @@ int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no,
>  		reg = ep_func->msi_cap + func_offset + PCI_MSI_DATA_32;
>  		msg_data = dw_pcie_readw_dbi(pci, reg);
>  	}
> -	aligned_offset = msg_addr_lower & (epc->mem->window.page_size - 1);
> -	msg_addr = ((u64)msg_addr_upper) << 32 |
> -			(msg_addr_lower & ~aligned_offset);
> +	msg_addr = ((u64)msg_addr_upper) << 32 | msg_addr_lower;
> +
> +	aligned_offset = msg_addr & (epc->mem->window.page_size - 1);
> +	msg_addr = ALIGN_DOWN(msg_addr, epc->mem->window.page_size);
>  	ret = dw_pcie_ep_map_addr(epc, func_no, 0, ep->msi_mem_phys, msg_addr,
>  				  epc->mem->window.page_size);
>  	if (ret)

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)