linux-kernel - Re: [PATCH v5 07/14] md: export helpers to stop sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 18 Feb 2024 10:35:33 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Song Liu <song@...nel.org>, Yu Kuai <yukuai1@...weicloud.com>
Cc: mpatocka@...hat.com, heinzm@...hat.com, xni@...hat.com,
 blazej.kucman@...ux.intel.com, agk@...hat.com, snitzer@...nel.org,
 dm-devel@...ts.linux.dev, jbrassow@....redhat.com, neilb@...e.de,
 shli@...com, akpm@...l.org, linux-kernel@...r.kernel.org,
 linux-raid@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH v5 07/14] md: export helpers to stop sync_thread

Hi,

在 2024/02/16 6:27, Song Liu 写道:
> On Thu, Feb 1, 2024 at 1:30 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
>>
> [...]
>> +
>>   static void idle_sync_thread(struct mddev *mddev)
>>   {
>>          mutex_lock(&mddev->sync_mutex);
>> -       clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
>>
>>          if (mddev_lock(mddev)) {
>>                  mutex_unlock(&mddev->sync_mutex);
>>                  return;
>>          }
>>
>> +       clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
>>          stop_sync_thread(mddev, false, true);
>>          mutex_unlock(&mddev->sync_mutex);
>>   }
>> @@ -4936,13 +4965,13 @@ static void idle_sync_thread(struct mddev *mddev)
>>   static void frozen_sync_thread(struct mddev *mddev)
>>   {
>>          mutex_lock(&mddev->sync_mutex);
>> -       set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
>>
>>          if (mddev_lock(mddev)) {
>>                  mutex_unlock(&mddev->sync_mutex);
>>                  return;
>>          }
>>
>> +       set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
>>          stop_sync_thread(mddev, false, false);
>>          mutex_unlock(&mddev->sync_mutex);
>>   }
> 
> The two changes above (moving set_bit) don't seem to belong
> to this patch. If they are still needed, please submit a separate
> patch.

Yes, they are not needed in this patchset. I forgot to remove them while
solving conflicts with other patches locally.

Thanks,
Kuai

> 
> Thanks,
> Song
> 
> .
>