linux-kernel - Re: [PATCH] irqchip/mbigen: Fix incorrect null pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a5nxbl3f.ffs@tglx>
Date: Sun, 18 Feb 2024 20:58:44 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: "chenjun (AM)" <chenjun102@...wei.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Cc: "xuqiang (M)" <xuqiang36@...wei.com>
Subject: Re: [PATCH] irqchip/mbigen: Fix incorrect null pointer check

On Sun, Feb 18 2024 at 03:13, chenjun (AM) wrote:
> 在 2024/2/13 18:09, Thomas Gleixner 写道:
>> On Mon, Jan 29 2024 at 21:00, Chen Jun wrote:
>> 
>> That's not about an incorrect NULL pointer check. That's about using a
>> function which is guaranteed to return NULL on your platform, no?
>> 
>>> bus_get_dev_root(&platform_bus_type) always returns NULL.
>> 
>> Lacks an explanation why this always returns NULL.
>> 
>
> Thank you for the reply.
>
> bus_get_dev_root returns sp->dev_root set in subsys_register.
> And subsys_register is not called by platform_bus_init.
>
> So, for platform_bus_type, bus_get_dev_root always returns NULL.

Please add this information to the change log.

Thanks,

        tglx