linux-kernel - Re: [RFC PATCH] x86/sgx: Remove 'reclaim' boolean parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40f95b90-8698-42dd-89d7-cd73d1e311b1@intel.com>
Date: Mon, 19 Feb 2024 07:56:58 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Haitao Huang <haitao.huang@...ux.intel.com>, jarkko@...nel.org
Cc: anakrish@...rosoft.com, bp@...en8.de, cgroups@...r.kernel.org,
 chrisyan@...rosoft.com, dave.hansen@...ux.intel.com, hpa@...or.com,
 kristen@...ux.intel.com, linux-kernel@...r.kernel.org,
 linux-sgx@...r.kernel.org, mikko.ylinen@...ux.intel.com, mingo@...hat.com,
 mkoutny@...e.com, seanjc@...gle.com, sohil.mehta@...el.com,
 tglx@...utronix.de, tim.c.chen@...ux.intel.com, tj@...nel.org,
 x86@...nel.org, yangjie@...rosoft.com, zhanb@...rosoft.com,
 zhiquan1.li@...el.com
Subject: Re: [RFC PATCH] x86/sgx: Remove 'reclaim' boolean parameters

On 2/19/24 07:39, Haitao Huang wrote:
> Remove all boolean parameters for 'reclaim' from the function
> sgx_alloc_epc_page() and its callers by making two versions of each
> function.
> 
> Also opportunistically remove non-static declaration of
> __sgx_alloc_epc_page() and a typo
> 
> Signed-off-by: Haitao Huang <haitao.huang@...ux.intel.com>
> Suggested-by: Jarkko Sakkinen <jarkko@...nel.org>
> ---
>  arch/x86/kernel/cpu/sgx/encl.c  | 56 +++++++++++++++++++++------
>  arch/x86/kernel/cpu/sgx/encl.h  |  6 ++-
>  arch/x86/kernel/cpu/sgx/ioctl.c | 23 ++++++++---
>  arch/x86/kernel/cpu/sgx/main.c  | 68 ++++++++++++++++++++++-----------
>  arch/x86/kernel/cpu/sgx/sgx.h   |  4 +-
>  arch/x86/kernel/cpu/sgx/virt.c  |  2 +-
>  6 files changed, 115 insertions(+), 44 deletions(-)

Jarkko, did this turn out how you expected?

I think passing around a function pointer to *only* communicate 1 bit of
information is a _bit_ overkill here.

Simply replacing the bool with:

enum sgx_reclaim {
	SGX_NO_RECLAIM,
	SGX_DO_RECLAIM
};

would do the same thing.  Right?

Are you sure you want a function pointer for this?