linux-kernel - Re: [PATCH v2 1/2] clocksource/drivers/timer-tegra186: add WDIOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZ96WS1F2H67.CCTTAWAZX7PF@gmail.com>
Date: Mon, 19 Feb 2024 17:18:46 +0100
From: "Thierry Reding" <thierry.reding@...il.com>
To: "Pohsun Su" <pohsuns@...dia.com>, <daniel.lezcano@...aro.org>,
 <tglx@...utronix.de>, <jonathanh@...dia.com>
Cc: <sumitg@...dia.com>, <linux-kernel@...r.kernel.org>,
 <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] clocksource/drivers/timer-tegra186: add
 WDIOC_GETTIMELEFT support

On Fri Feb 16, 2024 at 10:02 PM CET, Pohsun Su wrote:
[...]
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
[...]
> @@ -234,12 +239,49 @@ static int tegra186_wdt_set_timeout(struct watchdog_device *wdd,
>  	return 0;
>  }
>  
> +static unsigned int tegra186_wdt_get_timeleft(struct watchdog_device *wdd)
> +{
> +	struct tegra186_wdt *wdt = to_tegra186_wdt(wdd);
> +	u32 timeleft;
> +	u32 expiration;

One more thing I noticed: you could put both of these declarations on a
single line to make this a bit more compact.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)