linux-kernel - Re: [PATCH] interconnect: constify of_phandle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZ973FMYMJAO.PQ0Z5YLXZPPM@gmail.com>
Date: Mon, 19 Feb 2024 17:27:28 +0100
From: "Thierry Reding" <thierry.reding@...il.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>, "Konrad Dybcio"
 <konrad.dybcio@...aro.org>, "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Georgi Djakov" <djakov@...nel.org>,
 "Bjorn Andersson" <andersson@...nel.org>, "Sylwester Nawrocki"
 <s.nawrocki@...sung.com>, Artur Świgoń
 <a.swigon@...sung.com>, "Alim Akhtar" <alim.akhtar@...sung.com>, "Jonathan
 Hunter" <jonathanh@...dia.com>, <linux-gpio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] interconnect: constify of_phandle_args in xlate

On Fri Feb 16, 2024 at 2:59 PM CET, Krzysztof Kozlowski wrote:
> On 16/02/2024 14:55, Konrad Dybcio wrote:
> > On 16.02.2024 14:52, Krzysztof Kozlowski wrote:
> >> The xlate callbacks are supposed to translate of_phandle_args to proper
> >> provider without modifying the of_phandle_args.  Make the argument
> >> pointer to const for code safety and readability.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> ---
> >>  drivers/gpio/gpiolib-of.c              |  2 +-
> >>  drivers/interconnect/core.c            |  4 ++--
> >>  drivers/interconnect/qcom/icc-common.c |  3 ++-
> >>  drivers/interconnect/qcom/icc-common.h |  3 ++-
> >>  drivers/interconnect/samsung/exynos.c  |  2 +-
> >>  drivers/memory/tegra/mc.c              |  2 +-
> >>  drivers/memory/tegra/tegra124-emc.c    |  2 +-
> >>  drivers/memory/tegra/tegra124.c        |  2 +-
> >>  drivers/memory/tegra/tegra186-emc.c    |  2 +-
> >>  drivers/memory/tegra/tegra20-emc.c     |  2 +-
> >>  drivers/memory/tegra/tegra20.c         |  2 +-
> >>  drivers/memory/tegra/tegra30-emc.c     |  2 +-
> >>  drivers/memory/tegra/tegra30.c         |  2 +-
> >>  include/linux/interconnect-provider.h  | 11 ++++++-----
> >>  include/soc/tegra/mc.h                 |  7 ++++---
> > 
> > Ended up being a bit wider than just icc..
> > 
> > Looks sane apart from that
>
> Tegra memory controllers are also interconnect providers, so two subsystems.
>
> This patch should go via interconnect tree.

I think Konrad might have been referring to the GPIO hunk, which seems
out of place. For the Tegra parts, though:

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)